Skip site navigation (1) Skip section navigation (2)

RE: Suggested change in include/utils/elog.h

From: Magnus Hagander <mha(at)sollentuna(dot)net>
To: "'Bruce Momjian'" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "David R(dot) Favor" <dfavor(at)austin(dot)ibm(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: Suggested change in include/utils/elog.h
Date: 2000-09-30 08:28:53
Message-ID: 215896B6B5E1CF11BC5600805FFEA82103D97FEF@sirius.edu.sollentuna.se (view raw or flat)
Thread:
Lists: pgsql-hackers
If you do decide to prefix DEBUG, please consider prefixing at least ERROR
as well. It produces a lot of warnings when compiling on Win32 (ERROR is
already defined as part of the standard windows headers). It's just
warnings, though.

//Magnus


> Do other people have a comment on this.  I am inclined to leave it
> along.  This is the first complaint I have heard, and 
> elog(PGDEBUG) just
> looks funny.  We don't prefix NOTICE or ERROR.
> 
> 
> > In the file
> > 
> >    include/utils/elog.h
> > 
> > there is a macro named
> > 
> >    DEBUG
> > 
> > that conflicts with the perl5.6 macro DEBUG.
> > 
> > PostgreSQL would probably "play" better with other products if
> > the DEBUG macro had a prefix, maybe PGSQLDEBUG or similar.
> > 
> > Until there is some fix in this area, plperl will not build with
> > a version of perl that has debugging enabled.
> > 
> 
> 
> -- 
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
>   +  If your life is a hard drive,     |  830 Blythe Avenue
>   +  Christ can be your backup.        |  Drexel Hill, 
> Pennsylvania 19026
> 

Responses

pgsql-hackers by date

Next:From: MaurizioDate: 2000-09-30 09:02:34
Subject: Re: SIGSEGV in postgres 7.0.0 for QNX
Previous:From: Tom LaneDate: 2000-09-30 03:37:20
Subject: Re: ALTER TABLE DROP COLUMN

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group