Re: BUG #4266: regress test: could not dump unrecognized node type: 925

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: clefis(at)gmx(dot)de, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4266: regress test: could not dump unrecognized node type: 925
Date: 2008-06-26 21:28:39
Message-ID: 21467.1214515719@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> Only that outfuncs.c has very incomplete coverage of utility statements.

> Oh, so we don't guarantee that debug_print_parse will always work.

Well, we have never bothered to make it dump everything in the
utility-statement universe, and I don't especially want to start now ---
if that were worth doing we'd have done it before now.

I notice that _outQuery already contains a filter that's intended to
prevent warning chatter of exactly this type. I think it's probably at
least as logical to fix this issue by removing dumping of CreateStmt as
to try to ensure that we know how to dump everything that could appear
underneath CreateStmt ...

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Dave Page 2008-06-27 08:39:28 Re: BUG #4267: initdb fails
Previous Message Bruce Momjian 2008-06-26 21:22:13 Re: BUG #4266: regress test: could not dump unrecognized node type: 925