Skip site navigation (1) Skip section navigation (2)

Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: oleg(at)sai(dot)msu(dot)su, Denis de Bernardy <ddebernardy(at)yahoo(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Date: 2011-07-05 17:56:21
Message-ID: 21432.1309888581@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-testers
Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> I think that ripping out the change to btree_gist is also insufficient;
> we would also have to prevent other extensions from doing the same. That
> means documenting an odd special case, and testing for it when defining
> an opclass. And then we'd probably have to backpatch this kludge.

There is that.  I doubt it's worth back-patching, though.

> Something simpler seems possible here. The root of the problem is that
> we're being fooled by GiST opclasses when all we care about are BTree
> opclasses anyway. A simple fix would be to introduce a flag
> "found_btree_op". If we hit any BTree entries from pg_amop at all, then
> we're done after the loop is done. If not, then we negate the op and
> loop again.

Yeah, I had been thinking along the same lines.  It will require
duplicating the search loop, which is a bit annoying, but perhaps that
could be factored out as a subroutine.

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: giuseppe petazzoniDate: 2011-07-05 21:24:40
Subject: BUG #6091: Information
Previous:From: Jeff DavisDate: 2011-07-05 17:24:16
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)

pgsql-testers by date

Next:From: Jeff DavisDate: 2011-07-06 17:00:11
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Previous:From: Jeff DavisDate: 2011-07-05 17:24:16
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group