| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | "" <alr(dot)nospamforme(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #4941: pg_stat_statements crash |
| Date: | 2009-07-27 02:28:18 |
| Message-ID: | 21301.1248661698@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> We should call [Read dumpfile] routine only once even on Windows.
Seems to me that you should simply do the load only when found is false.
> How about executing the routine during AddinShmemInitLock is taken?
You should not hold AddinShmemInitLock any longer than really necessary.
I don't think there is a need for locking here anyway, though, since
found should be false only in the postmaster.
> The best solution might be to call shmem_startup_hook only once
> every platforms, but it is difficult without fork().
We're not changing that. This is a bug in pgss_shmem_startup.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Federico Aguirre | 2009-07-27 02:33:43 | BUG #4942: edb_apachephp.bin error |
| Previous Message | Itagaki Takahiro | 2009-07-27 02:11:19 | Re: BUG #4941: pg_stat_statements crash |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2009-07-27 02:52:24 | Re: generic explain options v3 |
| Previous Message | Itagaki Takahiro | 2009-07-27 02:11:19 | Re: BUG #4941: pg_stat_statements crash |