1. Going through the code, I noticed that quite a few files use 4 spaces for indent on most of their lines, but have some lines using tab characters. Usually it's newer patches that introduced the tabs, but not always. Mixing both kinds of indents is confusing.
2. Pgadmin3.wxs should not have hard-coded paths referring to "C:\Program Files". Some people have their program files directory on another drive, and anyone who is running 64-bit windows will find this doesn't work, because the directory is "C:\Program Files (x86)". Wixs has variables that point to the right one. Or use the environment variable "VCINSTALLDIR", but I think the former is easier.
3. For the same reason, pgAdmin code that searches for client software (pgDump) shouldn't assume "C:\Program Files". This doesn't work at all on 64-bit windows. The environment variables "%ProgramFiles(x86)%" or "%ProgramFiles%" points to the right directory (if they are set). "ProgramFiles(x86)" should be preferred if set, because that is where 32-bit apps like Postgres get installed. There may be a better way to do this.
4. Why do you include the VC 8 redistributable files directly, instead of using the standard merge modules: Microsoft_VC80_CRT_x86.msm and policy_8_0_Microsoft_VC80_CRT_x86.msm (usually in "C:\Program Files\Common Files\Merge Modules")?
5. The current installer files don't work for Visual Studio 2008, as compiles from that need the VC90 redistributables.
pgadmin-hackers by date
|Next:||From: Harald Armin Massa[legacy]||Date: 2009-02-28 12:20:32|
|Subject: Challenges with messages|
|Previous:||From: Chuck McDevitt||Date: 2009-02-27 23:45:41|
|Subject: Re: pgAdmin for Greenplum database?|