From:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:
Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc:
Josh Berkus <josh(at)agliodbs(dot)com>, Greg Smith <greg(at)2ndQuadrant(dot)com>,
Robert Haas <robertmhaas(at)gmail(dot)com>,
PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: We need to log aborted autovacuums
Date:
2011-01-17 21:08:12
Message-ID:
21002.1295298492@sss.pgh.pa.us (view raw or flat )
Thread:
2010-11-17 21:46:21 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-11-17 21:55:40 from "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
2010-11-17 22:50:49 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-11-17 23:31:44 from Josh Berkus <josh(at)agliodbs(dot)com>
2010-11-17 23:35:45 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-11-17 23:49:24 from Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
2010-11-17 23:52:47 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-01-05 06:55:02 from Greg Smith <greg(at)2ndquadrant(dot)com>
2011-01-05 12:29:39 from Magnus Hagander <magnus(at)hagander(dot)net>
2011-01-05 19:27:10 from Josh Berkus <josh(at)agliodbs(dot)com>
2011-01-05 22:56:51 from Robert Treat <rob(at)xzilla(dot)net>
2011-01-05 23:06:11 from Josh Berkus <josh(at)agliodbs(dot)com>
2011-01-07 04:11:36 from Greg Smith <greg(at)2ndquadrant(dot)com>
2011-01-07 04:33:23 from Greg Smith <greg(at)2ndquadrant(dot)com>
2011-01-07 19:00:20 from Josh Berkus <josh(at)agliodbs(dot)com>
2011-01-08 01:15:12 from Greg Smith <greg(at)2ndquadrant(dot)com>
2011-01-08 06:05:20 from David Fetter <david(at)fetter(dot)org>
2011-01-08 12:17:51 from Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
2011-01-15 09:47:56 from Greg Smith <greg(at)2ndquadrant(dot)com>
2011-01-15 16:14:12 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-01-15 19:29:54 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-01-16 16:23:16 from Greg Smith <greg(at)2ndquadrant(dot)com>
2011-01-16 16:47:35 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-01-16 17:18:22 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2011-01-16 18:08:03 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-01-16 18:08:36 from Greg Smith <greg(at)2ndquadrant(dot)com>
2011-01-16 18:20:54 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-01-16 19:19:47 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2011-01-16 20:50:08 from Josh Berkus <josh(at)agliodbs(dot)com>
2011-01-17 01:36:32 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2011-01-17 01:50:49 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-01-17 19:46:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-01-17 20:24:30 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2011-01-17 21:08:12 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-01-31 02:37:51 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-01-31 03:03:19 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2011-01-31 03:26:01 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-02-04 03:49:20 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-02-04 12:08:58 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-02-05 17:54:28 from Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
2011-02-05 18:40:08 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-02-05 20:20:57 from Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
2011-02-05 20:25:19 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-02-05 20:34:15 from Cédric Villemain <cedric(dot)villemain(dot)debian(at)gmail(dot)com>
2011-02-08 03:05:21 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-01-18 01:26:09 from Josh Berkus <josh(at)agliodbs(dot)com>
2011-01-18 02:12:13 from Robert Haas <robertmhaas(at)gmail(dot)com>
2011-01-18 03:04:08 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-01-18 06:41:29 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2011-01-16 18:22:38 from Greg Smith <greg(at)2ndquadrant(dot)com>
2011-01-16 18:26:38 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Lists:
pgsql-hackers
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> On Mon, 2011-01-17 at 14:46 -0500, Tom Lane wrote:
>> Do we actually need a lock timeout either? The patch that was being
>> discussed just involved failing if you couldn't get it immediately.
>> I suspect that's sufficient for AV. At least, nobody's made a
>> compelling argument why we need to expend a very substantially larger
>> amount of work to do something different.
> I have a patch to do this BUT the log message is harder. Until we grab
> the lock we can't confirm the table still exists, so we can't get the
> name for it. The whole point of this is logging the names of tables for
> which we have failed to AV. Suggestions?
As I said before, the correct place to fix this is in autovacuum.c,
which has the table name near at hand. If you insist on fixing it
somewhere else it's going to be very invasive.
regards, tom lane
In response to
Responses
pgsql-hackers by date
Next :From: Joel JacobsonDate: 2011-01-17 21:08:28Subject : Re: Bug in pg_describe_object, patch v2Previous :From : Dimitri FontaineDate : 2011-01-17 21:07:45Subject : Re: Bug in pg_describe_object, patch v2
