Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> FWIW I found another issue with this variable when I was experimenting with
> small block sizes. If you set the target <= the tuple header the toaster
> breaks. This is because it's doing unsigned arithmetic (Size is unsigned). I
> think the right solution is just to change it to use plain int32 arithmetic
> everywhere.
Somehow I can't get excited about that. If we ever do open things up to
allow user control of the target, we'd certainly constrain it to a sane
range.
regards, tom lane
In response to
Responses
pgsql-hackers by date
| Next: | From: Bruce Momjian | Date: 2007-11-05 16:11:04 |
| Subject: Re: Patch for testing query modes on pgbench |
| Previous: | From: Bruce Momjian | Date: 2007-11-05 16:10:39 |
| Subject: Re: Proposal: PL/pgSQL EXECUTE INTO USING (for 8.4) |
pgsql-committers by date
| Next: | From: Tom Lane | Date: 2007-11-05 16:21:05 |
| Subject: Re: pgsql: Document txid functions. |
| Previous: | From: Bruce Momjian | Date: 2007-11-05 16:06:20 |
| Subject: Re: pgsql: Document txid functions. |