| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Unify some tar functionality across different parts |
| Date: | 2013-01-02 16:44:32 |
| Message-ID: | 20486.1357145072@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Wed, Jan 2, 2013 at 5:36 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Why are these very tar-specific functions being declared in such a
>> globally visible spot as port.h? That seems like a bad idea on its
>> face. IMO stuff in port.h ought to be about as globally applicable
>> as, say, malloc().
> It's where we put most of the things from src/port in.
Might be time to revisit that, or perhaps better reconsider what we're
putting in src/port/. The idea that anything that we want in both
frontend and backend is a porting issue seems a bit busted in itself.
> I take it you suggest moving it to a special say include/pgtar.h file?
Works for me.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2013-01-02 16:50:45 | Re: pgsql: Fix background workers for EXEC_BACKEND |
| Previous Message | Andrew Dunstan | 2013-01-02 16:43:14 | Re: pgsql: Fix background workers for EXEC_BACKEND |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2013-01-02 17:19:06 | Re: Review of Row Level Security |
| Previous Message | Boszormenyi Zoltan | 2013-01-02 16:44:12 | Re: Big disconnect_and_exit cleanup in pg_basebackup |