| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords. |
| Date: | 2012-03-31 15:59:47 |
| Message-ID: | 20422.1333209587@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 03/31/2012 10:56 AM, Tom Lane wrote:
>> Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.
>>
>> Per buildfarm, this is now needed by contrib/pg_stat_statements.
> It seems to have broken mingw earlier now :-(
Ugh. It looks like ecpg (and also pg_dump) are defining symbols named
ScanKeywords and NumScanKeywords, but relying on the backend's
keywords.h to provide global declarations for those. And this doesn't
work once we PGDLLIMPORT-decorate those declarations.
The only simple fix I can see is to rename the symbols in ecpg and
pg_dump to something else. This is probably a good thing anyway to
reduce confusion. Anybody have another idea?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2012-03-31 16:52:37 | Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords. |
| Previous Message | Andrew Dunstan | 2012-03-31 15:41:01 | Re: pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-03-31 16:35:53 | Re: pg_dump incredibly slow dumping a single schema from a large db |
| Previous Message | Tom Lane | 2012-03-31 15:50:27 | Re: Speed dblink using alternate libpq tuple storage |