Skip site navigation (1) Skip section navigation (2)

Re: incompatible pointer types with newer zlib

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: incompatible pointer types with newer zlib
Date: 2012-02-24 16:10:16
Message-ID: 20273.1330099816@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On tor, 2012-02-23 at 10:17 -0500, Tom Lane wrote:
>> void * seems entirely reasonable given the two different usages, but
>> I would be happier if the patch added explicit casts whereever FH is
>> set to or used as one of these two types.

> That would add about 70 casts all over the place.  I don't think that
> will make things clearer or more robust.  I think we either leave it as
> my first patch for now or find a more robust solution with a union or
> something.

Hm.  Could we just create two separate fields?  It's not real clear to
me that forcing both these usages into a generic pointer buys much.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Yeb HavingaDate: 2012-02-24 16:25:45
Subject: Re: [v9.2] Add GUC sepgsql.client_label
Previous:From: Marko KreenDate: 2012-02-24 15:46:16
Subject: Re: Speed dblink using alternate libpq tuple storage

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group