Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] For review: Server instrumentation patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,Andreas Pflug <pgadmin(at)pse-consulting(dot)de>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>,Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Subject: Re: [HACKERS] For review: Server instrumentation patch
Date: 2005-08-13 19:05:51
Message-ID: 20271.1123959951@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
I wrote:
> I'll see about installing an initdb-time kluge to make it use OUT
> parameters.

Done:

regression=# SELECT * FROM pg_stat_file('postgresql.conf');
 length |         atime          |         mtime          |         ctime          | isdir
--------+------------------------+------------------------+------------------------+-------
  12578 | 2005-08-13 14:51:03-04 | 2005-08-13 14:50:32-04 | 2005-08-13 14:50:32-04 | f
(1 row)

I removed the separate pg_file_length() function, as it doesn't have any
significant notational advantage anymore; you can do

regression=# select (pg_stat_file('postgresql.conf')).length;
 length
--------
  12578
(1 row)

BTW, \df is no real help when it comes to stuff with OUT parameters;
it still says

regression=# \df pg_stat_file
                         List of functions
   Schema   |     Name     | Result data type | Argument data types
------------+--------------+------------------+---------------------
 pg_catalog | pg_stat_file | record           | text
(1 row)

Possibly we should try to improve that.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Martijn van OosterhoutDate: 2005-08-13 19:12:21
Subject: [PATCH] Clarify issues with SPI and C language function limitations
Previous:From: Tom LaneDate: 2005-08-13 18:02:23
Subject: Re: [HACKERS] For review: Server instrumentation patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group