Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Change replication connection log format to allow for a database

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: Simon Riggs <sriggs(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Change replication connection log format to allow for a database
Date: 2010-03-25 17:00:18
Message-ID: 20210.1269536418@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Heikki Linnakangas wrote:
>> I'm afraid this doesn't translate well:
>> 
>>> --- 222,232 ----
>>> */
>>> if (am_walsender)
>>> ereport(LOG,
>>> ! 				(errmsg("replication connection authorized: user=%s host=%s%s%s",
>>> ! 						port->user_name,
>>> ! 						port->remote_host, port->remote_port[0] ? " port=" : "",
>>> ! 						port->remote_port)));
>>> ! 
>>> else if (Log_connections)
>>> ereport(LOG,
>>> (errmsg("connection authorized: user=%s database=%s",

> Ok, I just realized that this was copy-pasted from BackendInitialize, so
> I guess it's OK as it is...

Two flat-out violations of our message style guidelines doesn't make it
right.  I agree with your proposed change for both.

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Simon RiggsDate: 2010-03-25 18:57:27
Subject: Re: pgsql: Change replication connection log format to allow for a database
Previous:From: Heikki LinnakangasDate: 2010-03-25 16:54:57
Subject: Re: pgsql: Change replication connection log format to allow for a database

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group