Re: POLA violation with \c service=

On Thu, Jan 08, 2015 at 08:04:47PM -0800, David Fetter wrote:
> On Mon, Jan 05, 2015 at 02:26:59PM -0800, David Fetter wrote:
> > On Tue, Dec 30, 2014 at 04:48:11PM -0800, David Fetter wrote:
> > > On Wed, Dec 17, 2014 at 08:14:04AM -0500, Andrew Dunstan wrote:
> > > >
> > > > Yeah, that's the correct solution. It should not be terribly difficult to
> > > > create a test for a conninfo string in the dbname parameter. That's what
> > > > libpq does after all. We certainly don't want psql to have to try to
> > > > interpret the service file. psql just needs to let libpq do its work in this
> > > > situation.
> > >
> > > This took a little longer to get time to polish than I'd hoped, but
> > > please find attached a patch which:
> > >
> > > - Correctly connects to service= and postgres(ql)?:// with \c
> > > - Disallows tab completion in the above cases
> > >
> > > I'd like to see about having tab completion actually work correctly in
> > > at least the service= case, but that's a matter for a follow-on patch.
> > >
> > > Thanks to Andrew Dunstan for the original patch, and to Andrew Gierth
> > > for his help getting it into shape.
> > >
> > > Cheers,
> > > David.
> >
> > I should mention that the patch also corrects a problem where the
> > password was being saved/discarded at inappropriate times. Please
> > push this patch to the back branches :)
>
> Per discussion with Stephen Frost, I've documented the previously
> undocumented behavior with conninfo strings and URIs.

Some C cleanups...

I think longer term we should see about having libpq export the
functions I've put in common.[ch], but that's for a later patch.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate