From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Thomas Fanghaenel <tfanghaenel(at)salesforce(dot)com> |
Cc: | Kevin Grittner <kgrittn(at)ymail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [SQL] Comparison semantics of CHAR data type |
Date: | 2014-02-14 02:47:01 |
Message-ID: | 20140214024701.GA3243@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-sql |
On Wed, Oct 16, 2013 at 02:17:11PM -0400, Bruce Momjian wrote:
> > > You can see the UTF8 case is fine because \n is considered greater
> > > than space, but in the C locale, where \n is less than space, the
> > > false return value shows the problem with
> > > internal_bpchar_pattern_compare() trimming the string and first
> > > comparing on lengths. This is exactly the problem you outline, where
> > > space trimming assumes everything is less than a space.
> >
> > For collations other than C some of those issues that have to do with
> > string comparisons might simply be hidden, depending on how strcoll()
> > handles inputs off different lengths: If strcoll() applies implicit
> > space padding to the shorter value, there won't be any visible
> > difference in ordering between bpchar and varchar values. If strcoll()
> > does not apply such space padding, the right-trimming of bpchar values
> > causes very similar issues even in a en_US collation.
I have added the attached C comment to explain the problem, and added a
TODO item to fix it if we ever break binary upgrading.
Does anyone think this warrants a doc mention?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
Attachment | Content-Type | Size |
---|---|---|
char.diff | text/x-diff | 1.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-02-14 02:48:09 | Re: HBA files w/include support? |
Previous Message | Jerry Sievers | 2014-02-14 02:24:27 | HBA files w/include support? |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2014-02-14 22:02:26 | Re: [SQL] Comparison semantics of CHAR data type |
Previous Message | Adrian Klaver | 2014-02-12 17:16:04 | Re: Re: Time AT TIME ZONE: false result using offset instead of time zone name |