| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. |
| Date: | 2013-03-26 20:20:19 |
| Message-ID: | 20130326202019.GA32088@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2013-03-26 13:14:53 -0700, Kevin Grittner wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> > Not happy with misc.c as a filename.
>
> We already have two misc.c files:
>
> src/backend/utils/adt/misc.c
> src/interfaces/ecpg/ecpglib/misc.c
>
> I much prefer not to repeat the same filename in different
> directories if we can avoid it.
>
> > How about pg_dump_utils.c or pg_dump_misc.c?
>
> Those seem reasonable to me.
I vote against including pg_ in the filename, for an implementation
private file that seems duplicative.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-03-26 21:43:54 | pgsql: Ignore invalid indexes in pg_dump. |
| Previous Message | Kevin Grittner | 2013-03-26 20:14:53 | Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-03-26 20:21:59 | Drastic performance loss in assert-enabled build in HEAD |
| Previous Message | Kevin Grittner | 2013-03-26 20:14:53 | Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt. |