Skip site navigation (1) Skip section navigation (2)

Re: BUG #7493: Postmaster messages unreadable in a Windows console

From: Noah Misch <noah(at)leadboat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alexander Law <exclusion(at)gmail(dot)com>,pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>,Magnus Hagander <magnus(at)hagander(dot)net>,Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: BUG #7493: Postmaster messages unreadable in a Windows console
Date: 2013-01-30 01:51:55
Message-ID: 20130130015155.GD3524@tornado.leadboat.com (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-generalpgsql-hackers
On Tue, Jan 29, 2013 at 09:54:04AM -0500, Tom Lane wrote:
> Alexander Law <exclusion(at)gmail(dot)com> writes:
> > Please look at the following l10n bug:
> > http://www.postgresql.org/message-id/502A26F1.6010109@gmail.com
> > and the proposed patch.
> 
> That patch looks entirely unsafe to me.  Neither of those functions
> should be expected to be able to run when none of our standard
> infrastructure (palloc, elog) is up yet.
> 
> Possibly it would be safe to do this somewhere around where we do
> GUC initialization.

Even then, I wouldn't be surprised to find problematic consequences beyond
error display.  What if all the databases are EUC_JP, the platform encoding is
KOI8, and some postgresql.conf settings contain EUC_JP characters?  Does the
postmaster not rely on its use of SQL_ASCII to allow those values?

I would look at fixing this by making the error output machinery smarter in
this area before changing the postmaster's notion of server_encoding.


In response to

Responses

pgsql-hackers by date

Next:From: Noah MischDate: 2013-01-30 02:04:56
Subject: Re: lazy_vacuum_heap()'s removal of HEAPTUPLE_DEAD tuples
Previous:From: Noah MischDate: 2013-01-30 01:34:24
Subject: Re: COPY FREEZE has no warning

pgsql-bugs by date

Next:From: Alexander LawDate: 2013-01-30 06:00:01
Subject: Re: BUG #7493: Postmaster messages unreadable in a Windows console
Previous:From: jan.mateDate: 2013-01-29 23:50:14
Subject: BUG #7838: pg_dump major bug

pgsql-general by date

Next:From: Tim UckunDate: 2013-01-30 02:58:54
Subject: Dropping default privileges.
Previous:From: Kevin GrittnerDate: 2013-01-29 23:09:26
Subject: Re: Optimizing select count query which often takes over 10 seconds

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group