Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Tolerate timeline switches while "pg_basebackup -X fetch" is run

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Tolerate timeline switches while "pg_basebackup -X fetch" is run
Date: 2013-01-29 18:55:44
Message-ID: 20130129185544.GE3945@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Heikki Linnakangas wrote:
> Tolerate timeline switches while "pg_basebackup -X fetch" is running.

I just noticed that this commit introduced a few error messages that
have a file argument which is not properly quoted:

+       ereport(ERROR,
+               (errcode_for_file_access(),
+                errmsg("requested WAL segment %s has already been removed",
+                       filename)));

+           ereport(ERROR,
+                   (errmsg("could not find WAL file %s", startfname)));

The first one seems to come from e57cd7f0a16, which is pretty old so
it's a bit strange that no one noticed.

Not sure what to do here ... should we just update everything including
the back branches, or just leave them alone and touch master only?

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2013-01-29 19:30:16
Subject: Re: erroneous restore into pg_catalog schema
Previous:From: Tom LaneDate: 2013-01-29 18:51:02
Subject: Re: enhanced error fields

pgsql-committers by date

Next:From: Tom LaneDate: 2013-01-29 22:09:17
Subject: pgsql: Provide database object names as separate fields in errormessag
Previous:From: Devrim GündüzDate: 2013-01-29 16:56:46
Subject: Re: pgsql: Fast promote mode skips checkpoint at end of recovery.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group