From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs |
Date: | 2013-01-09 14:58:28 |
Message-ID: | 20130109145828.GB13084@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2013-01-09 11:45:12 -0300, Alvaro Herrera wrote:
>
> How hard is the backend hit by palloc being now an additional function
> call? Would it be a good idea to make it (and friends) STATIC_IF_INLINE?
>
> > diff --git a/src/include/port/palloc.h b/src/include/port/palloc.h
> > new file mode 100644
> > index 0000000..a7900bf
> > --- /dev/null
> > +++ b/src/include/port/palloc.h
> > @@ -0,0 +1,19 @@
> > +/*
> > + * common.h
> > + * Common support routines for bin/scripts/
> > + *
> > + * Copyright (c) 2003-2013, PostgreSQL Global Development Group
> > + *
> > + * src/bin/scripts/common.h
> > + */
>
> You forgot to update the above comment.
*headbang*. Gah. I hate these comments... Will update, but won't send
anything again until more changes have accumulated.
Thanks!
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2013-01-09 15:16:04 | Re: PL/perl should fail on configure, not make |
Previous Message | Magnus Hagander | 2013-01-09 14:45:45 | Re: askpass program for libpq |