Skip site navigation (1) Skip section navigation (2)

Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs
Date: 2013-01-09 14:45:12
Message-ID: 20130109144512.GA4490@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackers
How hard is the backend hit by palloc being now an additional function
call?  Would it be a good idea to make it (and friends) STATIC_IF_INLINE?

> diff --git a/src/include/port/palloc.h b/src/include/port/palloc.h
> new file mode 100644
> index 0000000..a7900bf
> --- /dev/null
> +++ b/src/include/port/palloc.h
> @@ -0,0 +1,19 @@
> +/*
> + *	common.h
> + *		Common support routines for bin/scripts/
> + *
> + *	Copyright (c) 2003-2013, PostgreSQL Global Development Group
> + *
> + *	src/bin/scripts/common.h
> + */

You forgot to update the above comment.


-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2013-01-09 14:45:45
Subject: Re: askpass program for libpq
Previous:From: Bruce MomjianDate: 2013-01-09 13:58:26
Subject: Re: pg_upgrade with parallel tablespace copying

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group