Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Add support for LDAP URLs

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add support for LDAP URLs
Date: 2012-12-04 05:04:25
Message-ID: 20121204050425.GA7072@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committers
On Mon, Dec  3, 2012 at 11:46:56PM -0500, Bruce Momjian wrote:
> On Tue, Dec  4, 2012 at 04:31:51AM +0000, Peter Eisentraut wrote:
> > Add support for LDAP URLs
> > 
> > Allow specifying LDAP authentication parameters as RFC 4516 LDAP URLs.
> > 
> > Branch
> > ------
> > master
> > 
> > Details
> > -------
> > http://git.postgresql.org/pg/commitdiff/aa2fec0a18e4d23272c78916ef318078c920611a
> > 
> > Modified Files
> > --------------
> > doc/src/sgml/client-auth.sgml |   37 +++++++++++++++++++++++++
> > src/backend/libpq/auth.c      |    2 +-
> > src/backend/libpq/hba.c       |   59 ++++++++++++++++++++++++++++++++++++++++-
> > src/include/libpq/hba.h       |    1 +
> > 4 files changed, 97 insertions(+), 2 deletions(-)
> 
> I am seeing this compile error in Debian Squeeze:
> 
> 	hba.c: In function ‘parse_hba_auth_opt’:
> 	hba.c:1388: error: ‘LDAP_SCOPE_SUBTREE’ undeclared (first use in this function)
> 	hba.c:1388: error: (Each undeclared identifier is reported only once
> 	hba.c:1388: error: for each function it appears in.)
> 	hba.c:1451: error: ‘LDAPURLDesc’ undeclared (first use in this function)
> 	hba.c:1451: error: ‘urldata’ undeclared (first use in this function)
> 	hba.c:1452: warning: ISO C90 forbids mixed declarations and code
> 	hba.c:1452: warning: unused variable ‘rc’
> 	make[3]: *** [hba.o] Error 1

How do you like this attached patch to fix it?

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

Attachment: ldap.diff
Description: text/x-diff (1.1 KB)

In response to

Responses

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2012-12-04 09:34:29
Subject: pgsql: Track the timeline associated with minRecoveryPoint,for more sa
Previous:From: Bruce MomjianDate: 2012-12-04 04:46:56
Subject: Re: pgsql: Add support for LDAP URLs

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group