| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: --single-transaction hack to pg_upgrade does not work |
| Date: | 2012-12-01 17:05:32 |
| Message-ID: | 20121201170532.GN27120@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Dec 1, 2012 at 05:36:20PM +0100, Andres Freund wrote:
> On 2012-12-01 17:03:03 +0100, Andres Freund wrote:
> > Could we possibly allow adding enum values to a type which was just created in
> > this transaction? That shouldn't be too hard. At least easier than providing
> > the capability to pre-assign the next N oids...
>
> The attached patch does just that. Its *not* ready yet though, as it
> will be apparent for everyone who reads it ;)
>
> To really make that work in a reliable manner we would probably need
> an rd_createSubid for typcache entries instead of testing xmin as I have
> done here?
I can confirm that this patch allows pg_upgrade's test.sh to pass. :-)
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-12-01 17:06:02 | Re: --single-transaction hack to pg_upgrade does not work |
| Previous Message | Andrew Dunstan | 2012-12-01 17:01:17 | Re: --single-transaction hack to pg_upgrade does not work |