Peter Eisentraut wrote:
> Refactor flex and bison make rules
> 
> Numerous flex and bison make rules have appeared in the source tree
> over time, and they are all virtually identical, so we can replace
> them by pattern rules with some variables for customization.

Okapi has been failing sporadically on ecpg, and I wonder if it's
related to this change.  See, for example,
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=okapi&dt=2012-11-28%2018%3A15%3A01

icc -O3 -xSSSE3 -parallel -ip -mp1 -fno-strict-aliasing -g -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -DECPG_COMPILE -I../include -I../../../../src/interfaces/ecpg/include -I. -I. -DMAJOR_VERSION=4 -DMINOR_VERSION=9 -DPATCHLEVEL=0 -I../../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/et  -c -o parser.o parser.c
icc -O3 -xSSSE3 -parallel -ip -mp1 -fno-strict-aliasing -g -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -DECPG_COMPILE -I../include -I../../../../src/interfaces/ecpg/include -I. -I. -DMAJOR_VERSION=4 -DMINOR_VERSION=9 -DPATCHLEVEL=0 -I../../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/et  -c -o keywords.o keywords.c
parser.c(25): catastrophic error: could not open source file "preproc.h"
  #include "preproc.h"
                      ^

compilation aborted for parser.c (code 4)
make[4]: *** [parser.o] Error 4
make[4]: *** Waiting for unfinished jobs....
keywords.c(20): catastrophic error: could not open source file "preproc.h"
  #include "preproc.h"
                      ^

compilation aborted for keywords.c (code 4)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

• pgsql: Refactor flex and bison make rules at 2012-10-11 11:07:03 from Peter Eisentraut

Responses

• Re: pgsql: Refactor flex and bison make rules at 2012-11-28 20:47:56 from Andrew Dunstan

pgsql-hackers by date

Next:	From: Robert Haas	Date: 2012-11-28 19:53:36
	Subject: Re: Materialized views WIP patch
Previous:	From: Tom Lane	Date: 2012-11-28 19:09:11
	Subject: Re: Bugs in CREATE/DROP INDEX CONCURRENTLY

pgsql-committers by date

Next:	From: Andrew Dunstan	Date: 2012-11-28 20:47:56
	Subject: Re: pgsql: Refactor flex and bison make rules
Previous:	From: Alvaro Herrera	Date: 2012-11-28 16:37:36
	Subject: pgsql: Split out rmgr rm_desc functions into their own files