Skip site navigation (1) Skip section navigation (2)

Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi
Date: 2012-11-15 00:03:50
Message-ID: 20121115000350.GE6753@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Wed, Nov 14, 2012 at 06:57:13PM -0500, Tom Lane wrote:
> BTW, this patch isn't looking so good on Windows.  Buildfarm member
> chough says
> 
> "C:\prog\bf\root\HEAD\pgsql.11252\pgsql.sln" (default target) (1) ->
> (contrib\pg_upgrade target) -> 
>   .\contrib\pg_upgrade\relfilenode.c(202): warning C4003: not enough actual parameters for macro 'open'
> 
> 
> "C:\prog\bf\root\HEAD\pgsql.11252\pgsql.sln" (default target) (1) ->
> (contrib\pg_upgrade target) -> 
>   .\contrib\pg_upgrade\relfilenode.c(202): error C2059: syntax error : ')'
>   .\contrib\pg_upgrade\relfilenode.c(207): error C2181: illegal else without matching if
>   .\contrib\pg_upgrade\relfilenode.c(242): error C2059: syntax error : 'return'
>   .\contrib\pg_upgrade\relfilenode.c(243): error C2059: syntax error : '}'
> 
>     1 Warning(s)
>     4 Error(s)

OK, fixed by adding a third open() parameter of 0.  I see our other code
does this too.  I am not sure what those syntax errors are but I am
guessing the failed macro messed them up.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +


In response to

pgsql-hackers by date

Next:From: Andres FreundDate: 2012-11-15 00:27:46
Subject: logical changeset generation v3
Previous:From: Tom LaneDate: 2012-11-14 23:57:13
Subject: Re: pgsql: In pg_upgrade, copy fsm, vm, and extent files by checking for fi

pgsql-committers by date

Next:From: Peter EisentrautDate: 2012-11-15 05:06:12
Subject: pgsql: doc: Put commas in the right place on pg_restore reference page
Previous:From: Bruce MomjianDate: 2012-11-15 00:01:34
Subject: pgsql: In pg_upgrade, add third meaningless parameter to open().

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group