Skip site navigation (1) Skip section navigation (2)

getopt() and strdup()

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: getopt() and strdup()
Date: 2012-10-08 18:40:26
Message-ID: 20121008184026.GA28752@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
A while ago I noticed that in some places we strdup/pg_strdup() optarg
strings from getopt(), and in some places we don't.

If we needed the strdup(), the missing cases should generate errors.  If
we don't need them, the strdup() is unnecessary, and research confirms
they are unnecessary.  Should we remove the extra strdup/pg_strdup()
calls, for consistency.

I think we might have had old platforms that required it, but none are
still supported today.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +


Responses

pgsql-hackers by date

Next:From: Gavin FlowerDate: 2012-10-08 18:57:38
Subject: Re: Improving psql \ds
Previous:From: Dean RasheedDate: 2012-10-08 18:33:13
Subject: Re: [v9.3] Row-Level Security

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group