Re: pgtesttiming.sgml, FreeBSD command output

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-docs <pgsql-docs(at)postgresql(dot)org>
Subject: Re: pgtesttiming.sgml, FreeBSD command output
Date: 2012-08-30 22:38:21
Message-ID: 20120830223821.GG32350@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs


Patch attached and applied for PG 9.3.

---------------------------------------------------------------------------

On Fri, Jul 6, 2012 at 02:09:00PM -0700, Josh Kupershmidt wrote:
> On Fri, Jul 6, 2012 at 1:33 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> > On fre, 2012-07-06 at 13:21 -0700, Josh Kupershmidt wrote:
>
> >> <screen>
> >> dmesg | grep "Timecounter"
> >> sysctl kern.timecounter.hardware=TSC
> >> </screen>
> >>
> >> First, grep is case-sensitive by default, so that line of output
> >> shouldn't have matched at all, right?
> >
> > I don't think this was meant to say that the second line is the output
> > of the first. I read this as two separate commands. But I agree this
> > part is a bit unclear.
>
> Oh, I see now. The <screen> sections above and below that one were
> including output, and I was just expecting the same here.
>
> One way to fix would be to include shell prompts and outputs for both
> commands (patch Option 1, attached). Or, if we don't want to bother
> including output, as the section does now, maybe we could at least
> include the shell prompts and mention that output is excluded (patch
> Option 2).
>
> I've also attached an unrelated typofix I noticed for the same page.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachment Content-Type Size
timer.diff text/x-diff 1.5 KB

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Bruce Momjian 2012-08-31 03:52:54 Re: somewhat wrong archive_command example
Previous Message Bruce Momjian 2012-08-30 21:58:48 Re: Out of date advice about SIGTERM'ing backends