Hi,

It seems that when Heikki added the multi_insert code the following comment in 
htup.h wasn't updated:
/*
 * We ran out of opcodes, so heapam.c now has a second RmgrId.	These opcodes
 * are associated with RM_HEAP2_ID, but are not logically different from
 * the ones above associated with RM_HEAP_ID.  We apply XLOG_HEAP_OPMASK,
 * although currently XLOG_HEAP_INIT_PAGE is not used for any of these.
 */
#define XLOG_HEAP2_FREEZE		0x00
#define XLOG_HEAP2_CLEAN		0x10
/* 0x20 is free, was XLOG_HEAP2_CLEAN_MOVE */
#define XLOG_HEAP2_CLEANUP_INFO 0x30
#define XLOG_HEAP2_VISIBLE		0x40
#define XLOG_HEAP2_MULTI_INSERT	0x50

I suggest simply to remove the "although currently XLOG_HEAP_INIT_PAGE is not 
used for any of these" part.


Andres

Responses

• Re: outdated comment in heapam.c at 2012-05-03 16:46:34 from Heikki Linnakangas

pgsql-hackers by date

Next:	From: Merlin Moncure	Date: 2012-05-03 13:19:01
	Subject: Re: Temporary tables under hot standby
Previous:	From: Magnus Hagander	Date: 2012-05-03 13:01:25
	Subject: Re: ALTER DATABASE and datallowconn