Re: [9.2] Confusion over CacheRegisterSyscacheCallback

From: Marko Kreen <markokr(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Postgres Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [9.2] Confusion over CacheRegisterSyscacheCallback
Date: 2012-03-07 09:50:11
Message-ID: 20120307095011.GA32302@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 06, 2012 at 04:27:11PM -0500, Tom Lane wrote:
> Marko Kreen <markokr(at)gmail(dot)com> writes:
> > On Tue, Mar 06, 2012 at 11:10:38AM -0500, Tom Lane wrote:
> >> Why would you need to know that? The reason the calculation function
> >> is static is that there's no apparent need to expose that information
> >> outside the syscache subsystem.
>
> > Because I need to invalidate my own internal state that corresponds
> > to particular system catalog row?
>
> > In current case (plproxy) I need to invalidate libpq connections
> > that are created from particular foreign server entry.
>
> [ shrug... ] You could just flush 'em all, which is what most existing
> inval callbacks do. Admittedly a libpq connection is a bit more
> expensive than the average bit of invalidatable state, but how often
> does pg_foreign_server get updated?

The frequency does not matter, it's the impact of what happens
when it does get updated. There may be many connections.

> Or you could do like setrefs.c does, and assume you know how to
> calculate the hash value for an OID-keyed cache.

Ok, the hashoid() hack works. But please take it as report from
the ground that this API is useful outside of core and it would
be good if it stays useful.

--
marko

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-03-07 10:02:43 Re: foreign key locks, 2nd attempt
Previous Message Gokulakannan Somasundaram 2012-03-07 09:24:11 Re: foreign key locks, 2nd attempt