Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Re: Speed dblink using alternate libpq tuple storage
Hello, this is new version of the patch. # This patch is based on the commit # 2bbd88f8f841b01efb073972b60d4dc1ff1f6fd0 @ Feb 13 to avoid the # compile error caused by undeclared LEAKPROOF in kwlist.h. > It must free the PGresults that PQgetResult() returns. I'm sorry. It slipped out of my mind. Add PQclear() for the return value. > Also, please fix 2 issues mentined here: - PQsetRowProcessorErrMsg() now handles msg as const string. - Changed the order of the parameters of the type PQrowProcessor. New order is (PGresult *res, PGrowValue *columns, void *params). # PQsetRowProcessorErrMsg outside of callback is not implemented. - Documentation and dblink are modified according to the changes above. By the way, I would like to ask you one question. What is the reason why void* should be head or tail of the parameter list? regards, -- Kyotaro Horiguchi NTT Open Source Software Center
Attachment: early_exit_20120223.diff
Description: text/x-patch (2.1 KB)
Description: text/x-patch (2.1 KB)
Attachment: dblink_use_rowproc_20120223.patch
Description: text/x-patch (12.8 KB)
Description: text/x-patch (12.8 KB)
Attachment: libpq_rowproc_doc_20120223.patch
Description: text/x-patch (9.5 KB)
Description: text/x-patch (9.5 KB)
Attachment: libpq_rowproc_20120223.patch
Description: text/x-patch (23.5 KB)
Description: text/x-patch (23.5 KB)
In response to
- Re: Speed dblink using alternate libpq tuple storage at 2012-02-21 23:36:30 from Marko Kreen
Responses
- Re: Speed dblink using alternate libpq tuple storage at 2012-02-23 12:34:16 from Marko Kreen
pgsql-hackers by date
Next: From: Peter Eisentraut Date: 2012-02-23 11:08:51 Subject: overriding current_timestamp Previous: From: Daniel Farina Date: 2012-02-23 09:58:44 Subject: pg_stat_statements normalization: re-review