Skip site navigation (1) Skip section navigation (2)

Re: ecpglib use PQconnectdbParams

From: Marko Kreen <markokr(at)gmail(dot)com>
To: Christian Ullrich <chris(at)chrullrich(dot)net>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>,Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: ecpglib use PQconnectdbParams
Date: 2012-02-06 16:50:44
Message-ID: 20120206165044.GA16393@gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
On Fri, Feb 03, 2012 at 01:15:30PM +0100, Christian Ullrich wrote:
> * Peter Eisentraut wrote:
> >I noticed ecpglib still uses PQconnectdb() with a craftily assembled
> >connection string.  Here is a patch to use PQconnectdbParams() instead.
> 
> +	const char *conn_keywords[6];
> +	const char *conn_values[6];
> 
> Shouldn't these be [7]? You can have up to 6 items, plus the terminator.

This bug is now in GIT.

-- 
marko


In response to

pgsql-hackers by date

Next:From: Robert HaasDate: 2012-02-06 16:57:30
Subject: Re: about type cast
Previous:From: Robert HaasDate: 2012-02-06 16:19:14
Subject: Re: freezing multixacts

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group