| From: | Abhijit Menon-Sen <ams(at)toroid(dot)org> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: proposal: better support for debugging of overloaded functions |
| Date: | 2012-01-26 15:28:12 |
| Message-ID: | 20120126152812.GC30769@toroid.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At 2011-11-24 17:44:16 +0100, pavel(dot)stehule(at)gmail(dot)com wrote:
>
> patch is relative long, but almost all are changes in regress tests.
> Changes in plpgsql are 5 lines
The change looks good in principle. The patch applies to HEAD with a bit
of fuzz and builds fine… but it fails tests, because it's incomplete.
Pavel, your patch doesn't contain any changes to pl_exec.c. Did you just
forget to submit them? Anyway, some errcontext() calls need to be taught
to print ->fn_signature rather than ->fn_name. I made those changes, and
found some more failing tests.
Updated patch attached. Ready for committer.
-- ams
| Attachment | Content-Type | Size |
|---|---|---|
| pavel-plpgsql-fnsig.diff | text/x-diff | 31.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-01-26 15:31:56 | Re: Client Messages |
| Previous Message | Robert Haas | 2012-01-26 15:19:31 | Re: Different error messages executing CREATE TABLE or ALTER TABLE to create a column "xmin" |