Skip site navigation (1) Skip section navigation (2)

npgsql - Npgsql2: Applied Gildas Prime patch with Gendarme report

From: fxjr(at)pgfoundry(dot)org (User Fxjr)
To: pgsql-committers(at)postgresql(dot)org
Subject: npgsql - Npgsql2: Applied Gildas Prime patch with Gendarme report
Date: 2012-01-12 18:44:59
Message-ID: 20120112184459.6D7631D8C71F@pgfoundry.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------

Applied Gildas Prime patch with Gendarme report corrections:

Avoid concatenating chars rule ( i.e Unneeded boxing)
A recursive method was found (Method remove in NpgsqlParameterCollection)
Disposable fields should be disposed
Do not lock on this  ( lock(this) makes very difficult to ensure that the locking is done correctly.)
Ensure that local variables are disposed surrounding them by using()

Modified Files:
--------------
    Npgsql2/src/Npgsql:
        Cache.cs (r1.1 -> r1.2)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/Cache.cs?r1=1.1&r2=1.2)
        NpgsqlCommand.cs (r1.58 -> r1.59)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/NpgsqlCommand.cs?r1=1.58&r2=1.59)
        NpgsqlCommandBuilder.cs (r1.20 -> r1.21)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/NpgsqlCommandBuilder.cs?r1=1.20&r2=1.21)
        NpgsqlConnector.cs (r1.38 -> r1.39)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/NpgsqlConnector.cs?r1=1.38&r2=1.39)
        NpgsqlState.cs (r1.23 -> r1.24)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/NpgsqlState.cs?r1=1.23&r2=1.24)
        PGUtil.cs (r1.16 -> r1.17)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/PGUtil.cs?r1=1.16&r2=1.17)
        NpgsqlConnectorPool.cs (r1.21 -> r1.22)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/Npgsql/NpgsqlConnectorPool.cs?r1=1.21&r2=1.22)
    Npgsql2/src/NpgsqlTypes:
        BitString.cs (r1.5 -> r1.6)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/src/NpgsqlTypes/BitString.cs?r1=1.5&r2=1.6)

pgsql-committers by date

Next:From: Tom LaneDate: 2012-01-12 19:18:31
Subject: pgsql: Tweak duplicate-index-column regression test to avoid localesen
Previous:From: Fujii MasaoDate: 2012-01-12 10:37:23
Subject: Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group