| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jim Nasby <jim(at)nasby(dot)net>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, aidan(at)highrise(dot)ca, stark(at)mit(dot)edu |
| Subject: | Re: 16-bit page checksums for 9.2 |
| Date: | 2012-01-06 10:36:08 |
| Message-ID: | 201201061136.08476.andres@anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Friday, January 06, 2012 11:30:53 AM Simon Riggs wrote:
> On Fri, Jan 6, 2012 at 1:10 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > * Simon Riggs (simon(at)2ndQuadrant(dot)com) wrote:
> >> I discover that non-all-zeroes holes are fairly common, just not very
> >> frequent.
> >
> > Curious, might be interesting to find out why.
> >
> >> That may or may not be a problem, but not something to be dealt with
> >> here and now.
> >
> > But I agree that it's not the job of this patch/effort. It sounds like
> > we have clear indication, however, that those areas, as they are not
> > necessairly all zeros, should be included in the checksum.
>
> Disagree. Full page writes ignore the hole, so its appropriate to do
> so here also.
Well, ignoriging them in fpw has clear space benefits. Ignoring them while
checksumming doesn't have that much of a benefit.
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2012-01-06 11:13:25 | Re: FATAL: bogus data in lock file "postmaster.pid": "" |
| Previous Message | Simon Riggs | 2012-01-06 10:30:53 | Re: 16-bit page checksums for 9.2 |