Re: pgsql: Fix Perl copyright script to skip .git subdirectory; running it

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix Perl copyright script to skip .git subdirectory; running it
Date: 2012-01-02 00:47:35
Message-ID: 20120102004735.GC24093@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, Jan 01, 2012 at 07:24:40PM -0500, Bruce Momjian wrote:
> On Sun, Jan 01, 2012 at 07:05:24PM -0500, Andrew Dunstan wrote:
> >
> >
> > On 01/01/2012 05:59 PM, Bruce Momjian wrote:
> > >Fix Perl copyright script to skip .git subdirectory; running it on
> > >those files corrupts the index.
> >
> >
> > This patch looks a bit dubious. Instead of:
> >
> > if ($File::Find::name =~ m{^\./\.git$})
> >
> > I'd use:
> >
> > if ($_ eq '.git')
>
> The question was whether we wanted to skip non-top-of-tree .git
> directories. I wasn't sure we wanted to do that. Do we?

Thanks, done.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2012-01-02 00:47:57 Re: pgsql: Fix Perl copyright script to skip .git subdirectory; running it
Previous Message Bruce Momjian 2012-01-02 00:44:36 Re: pgsql: Update copyright notices for year 2012.