Skip site navigation (1) Skip section navigation (2)

[PATCH v2] Use CC atomic builtins as a fallback

From: Martin Pitt <mpitt(at)debian(dot)org>
To: pgsql-bugs(at)postgresql(dot)org
Subject: [PATCH v2] Use CC atomic builtins as a fallback
Date: 2011-12-19 17:11:45
Message-ID: 20111219171145.GN2972@piware.de (view raw or flat)
Thread:
Lists: pgsql-bugs
Robert Haas [2011-12-19  9:31 -0500]:
> -1.  Absent some evidence that gcc's implementations are superior to
> ours, I think we should not change stuff that works now.  That's
> likely to lead to subtle bugs that are hard to find and perhaps
> dependent on the exact compiler version used.
> 
> But I'm completely cool with doing this for platforms where we haven't
> otherwise got an implementation.  Any port in a storm.

The updated patch only uses the gcc builtins if there is no explicit
implementation, but drops the arm one as this doesn't work on ARMv7
and newer, as stated in the original mail.

Thanks,

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)

In response to

Responses

pgsql-bugs by date

Next:From: Noah MischDate: 2011-12-19 20:03:41
Subject: Re: [PATCH] Use CC atomic builtins if available [was: Re: TASpatch for building on armel/armhf thumb]
Previous:From: Heikki LinnakangasDate: 2011-12-19 16:18:43
Subject: Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb]

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group