Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Add file-fdw documentation example.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add file-fdw documentation example.
Date: 2011-12-04 16:10:27
Message-ID: 201112041610.pB4GARx05920@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committers
Magnus Hagander wrote:
> On Thu, Dec 1, 2011 at 18:58, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> > On 12/1/11 7:01 AM, Magnus Hagander wrote:
> >> On Thu, Dec 1, 2011 at 15:58, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> >>>
> >>>
> >>> On 12/01/2011 09:34 AM, Bruce Momjian wrote:
> >>>>
> >>>> Add file-fdw documentation example.
> >>>>
> >>>> Josh Berkus
> >>>
> >>>
> >>> This example appears to be wrong: the extension creates the FDW for you, and
> >>> doing it yourself again will result in an error.
> >>
> >> Yeah, that was even pointed out in my review of the original patch....
> >
> > I'd swear I sent in a corrected patch. ?Lemme look for it.
> 
> Not waiting for this, I've just removed the incorrect instructions.

Josh told me on Friday that he would apply a fix this weekend, but at
this point he can restore the patch and fix it if he wants.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

In response to

Responses

pgsql-committers by date

Next:From: Andrew DunstanDate: 2011-12-04 16:48:41
Subject: pgsql: Add a \setenv command to psql.
Previous:From: Magnus HaganderDate: 2011-12-04 16:00:26
Subject: pgsql: Remove incorrect instructions to run CREATE FOREIGN DATAWRAPPER

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group