Skip site navigation (1) Skip section navigation (2)

Re: BUG #6216: Calling PQconnectdbParams from C++ with a char**

From: Lionel Elie Mamane <lionel(at)mamane(dot)lu>
To: Craig Ringer <ringerc(at)ringerc(dot)id(dot)au>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6216: Calling PQconnectdbParams from C++ with a char**
Date: 2011-09-21 08:25:17
Message-ID: 20110921082517.GA28080@capsaicin.mamane.lu (view raw or flat)
Thread:
Lists: pgsql-bugs
ghtOn Wed, Sep 21, 2011 at 07:29:23AM +0800, Craig Ringer wrote:
> On 21/09/2011 12:05 AM, Lionel Elie Mamane wrote:

>>Bug reference:      6216
>>Logged by:          Lionel Elie Mamane
>>Email address:      lionel(at)mamane(dot)lu

>> In C++, a "char**" value is not convertible to a "const char**"
>> value, (...)

>> This means one cannot call libpq's PQconnectdbParams and friends
>> passing them a "char**" value for keywords and/or values, as these
>> arguments are declared "const char**".

> Lionel: Can I get you to add the patch to the commitfest app?

> https://commitfest.postgresql.org/

Sure.

Topic "performance" is not right, but only value I was allowed to put,
and it wanted a value...

I added my initial patch, and as far as I understand, I have to send
the revised patch to the list before I can register it at the
commitfest. So here is my revised patch, that uses "const char *const * "
like elsewhere in the same file instead of "char const* const*".

-- 
Lionel

Attachment: 6216_constpp_v2.patch
Description: text/x-diff (3.6 KB)

In response to

Responses

pgsql-bugs by date

Next:From: Robert HaasDate: 2011-09-21 14:55:19
Subject: Re: BUG #6205: ERROR: temporary tables cannot specify a schema name
Previous:From: pratikchiraniaDate: 2011-09-21 07:16:58
Subject: Re: Timezone issues with Postrres

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group