Skip site navigation (1) Skip section navigation (2)

Re: 'literal' for numbers

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-documentation <pgsql-docs(at)postgresql(dot)org>
Subject: Re: 'literal' for numbers
Date: 2011-09-05 15:56:03
Message-ID: 201109051556.p85Fu3Q05428@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-docspgsql-hackers
Bruce Momjian wrote:
> > So I guess I'm back agreeing with you.  Basically, it seems like we
> > ought to use <literal> if it's being used as a value that the user
> > might want to supply (e.g. "if you set this parameter to 0, then no
> > statements will be logged).  It shouldn't use <literal> if it's just
> > being used as a number (e.g. "this query will return all airplanes
> > with a height of less than 30,000 feet").  The cases I'm unsure about
> > are the ones where we're talking about a return value (e.g. in the
> > event of an error, this function will return -1).
> 
> Robert, based on your logic, the 'return -1' should not be literal
> because no one would type that in.  Unless I hear otherwise I will work
> on a patch to match the rules you outlined above.

FYI, here is what I thought was Robert's conclusion on this.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

In response to

pgsql-docs by date

Next:From: Bruce MomjianDate: 2011-09-05 16:50:24
Subject: Re: Building PDFs error: \pdfendlink ended up in different nesting level than \pd
Previous:From: Bruce MomjianDate: 2011-09-05 15:51:35
Subject: Use of literal in SGML docs

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2011-09-05 15:56:34
Subject: Re: [GENERAL] pg_upgrade problem
Previous:From: Bruce MomjianDate: 2011-09-05 15:51:35
Subject: Use of literal in SGML docs

pgsql-committers by date

Next:From: Tom LaneDate: 2011-09-05 15:59:22
Subject: Re: [COMMITTERS] pgsql: Clean up the #include mess a little.
Previous:From: Bruce MomjianDate: 2011-09-05 15:51:35
Subject: Use of literal in SGML docs

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group