From:
Bruce Momjian <bruce(at)momjian(dot)us>
To:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:
Alvaro Herrera <alvherre(at)commandprompt(dot)com>,
Jeremy Drake <pgsql(at)jdrake(dot)com>,
pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include
in cube contrib --- caused crash on a Ge
Date:
2011-09-04 04:30:43
Message-ID:
201109040430.p844Uho00500@momjian.us (view raw or flat )
Thread:
2011-09-01 11:22:43 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-01 14:10:12 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-01 14:49:36 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-01 15:42:46 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-01 18:07:11 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 06:48:31 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-02 15:20:50 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 15:38:28 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2011-09-02 16:11:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-02 16:44:28 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 16:52:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-03 05:54:33 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-03 14:23:09 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-03 14:39:15 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 07:13:53 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-04 07:29:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-05 07:07:49 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-05 13:45:09 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-05 19:53:55 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-05 19:55:51 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-05 20:19:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-03 14:35:41 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 16:53:12 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2011-09-04 00:51:13 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 01:08:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-04 01:25:17 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 01:48:38 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-04 04:30:43 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 05:18:01 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-12 19:11:21 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Lists:
pgsql-committers pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> You seem to have entirely missed the point of Alvaro's remark, which is
> >> that you've got xlog.h including walsender.h (still) as well as
> >> walsender.h including xlog.h. That's broken.
>
> > Oh, OK, done. xlog.h removed from walsender.h and tested.
>
> I would have gone the other way on that one, if possible. Seems like
> xlog.h ought to be the lower-level file.
Agreed. Let me work on that.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
In response to
Responses
pgsql-hackers by date
Next :From: Tom LaneDate: 2011-09-04 05:13:41Subject : pgsql: Clean up the #include mess a little.Previous :From : Satoshi NagayasuDate : 2011-09-04 03:56:15Subject : xlogdump 0.4.0
pgsql-committers by date
Next :From: Tom LaneDate: 2011-09-04 05:13:41Subject : pgsql: Clean up the #include mess a little.Previous :From : Tom LaneDate : 2011-09-04 02:19:44Subject : pgsql: Remove unnecessary and circular #include.
