| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Jeremy Drake <pgsql(at)jdrake(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Date: | 2011-09-04 00:51:13 |
| Message-ID: | 201109040051.p840pDZ14908@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera wrote:
> Excerpts from Bruce Momjian's message of vie sep 02 12:20:50 -0300 2011:
>
> > Wow, that is interesting. So the problem is the inclusion of
> > replication/walsender.h in xlog.h. Hard to see how that could cause the
> > cube regression tests to fail, but of course, it is.
>
> Hmm, so you included walsender.h into xlog.h? That seems a bit funny
> considering that walsender.h already includes xlog.h. It seems the
> reason for this is only the AllowCascadeReplication() definition. Maybe
> that should go elsewhere instead, for example walsender.h?
Moved to walsender.h. Thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-09-04 01:08:41 | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Previous Message | Bruce Momjian | 2011-09-04 00:46:51 | pgsql: Move AllowCascadeReplication() define from xlog.h to replication |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-09-04 01:08:41 | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Previous Message | Tom Lane | 2011-09-03 23:58:12 | Re: pg_upgrade automatic testing |