From:
Bruce Momjian <bruce(at)momjian(dot)us>
To:
Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc:
Jeremy Drake <pgsql(at)jdrake(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,
pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:
Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube
contrib --- caused crash on a Ge
Date:
2011-09-04 00:51:13
Message-ID:
201109040051.p840pDZ14908@momjian.us (view raw or flat )
Thread:
2011-09-01 11:22:43 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-01 14:10:12 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-01 14:49:36 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-01 15:42:46 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-01 18:07:11 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 06:48:31 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-02 15:20:50 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 15:38:28 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2011-09-02 16:11:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-02 16:44:28 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 16:52:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-03 05:54:33 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-03 14:23:09 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-03 14:39:15 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 07:13:53 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-04 07:29:00 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-05 07:07:49 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-05 13:45:09 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-05 19:53:55 from Jeremy Drake <pgsql(at)jdrake(dot)com>
2011-09-05 19:55:51 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-05 20:19:19 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-03 14:35:41 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-02 16:53:12 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2011-09-04 00:51:13 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 01:08:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-04 01:25:17 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 01:48:38 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-04 04:30:43 from Bruce Momjian <bruce(at)momjian(dot)us>
2011-09-04 05:18:01 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2011-09-12 19:11:21 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Lists:
pgsql-committers pgsql-hackers
Alvaro Herrera wrote:
> Excerpts from Bruce Momjian's message of vie sep 02 12:20:50 -0300 2011:
>
> > Wow, that is interesting. So the problem is the inclusion of
> > replication/walsender.h in xlog.h. Hard to see how that could cause the
> > cube regression tests to fail, but of course, it is.
>
> Hmm, so you included walsender.h into xlog.h? That seems a bit funny
> considering that walsender.h already includes xlog.h. It seems the
> reason for this is only the AllowCascadeReplication() definition. Maybe
> that should go elsewhere instead, for example walsender.h?
Moved to walsender.h. Thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
In response to
Responses
pgsql-hackers by date
Next :From: Tom LaneDate: 2011-09-04 01:08:41Subject : Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge Previous :From : Tom LaneDate : 2011-09-03 23:58:12Subject : Re: pg_upgrade automatic testing
pgsql-committers by date
Next :From: Tom LaneDate: 2011-09-04 01:08:41Subject : Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge Previous :From : Bruce MomjianDate : 2011-09-04 00:46:51Subject : pgsql: Move AllowCascadeReplication() define from xlog.h toreplication
