Skip site navigation (1) Skip section navigation (2)

Re: Removal of useless include references

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Removal of useless include references
Date: 2011-09-01 14:53:51
Message-ID: 201109011453.p81ErpM10908@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Excerpts from Bruce Momjian's message of jue sep 01 11:04:33 -0300 2011:
> >> I have re-run the script and applied the result, again tested on BSD and
> >> Linux.   I will monitor the buildfarm for possible failures.
> 
> > I think anything of this sort should be tested on Windows too.
> 
> Well, if Windows is broken we'll find out soon enough from the
> buildfarm.  My recollection from the last go-round is that the pain
> points were in non-default #define options that Bruce hadn't tested
> and that no buildfarm critter exercised either, such as LOCK_DEBUG.

Ah, but this time I only removed includes for files I could compile with
all #if markers removed.  It only got 5.8k diff lines out a possible
6.8k lines, but this seems like an acceptable cost for greater
reliability.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

In response to

pgsql-hackers by date

Next:From: Jeremy DrakeDate: 2011-09-01 15:42:46
Subject: Re: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge
Previous:From: Bruce MomjianDate: 2011-09-01 14:51:41
Subject: Re: Removal of useless include references

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group