Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Allow more include files to be compiled in their own by adding m

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Allow more include files to be compiled in their own by adding m
Date: 2011-09-01 02:07:52
Message-ID: 201109010207.p8127qL23625@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committers
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Allow more include files to be compiled in their own by adding missing
> > include dependencies.
> 
> This patch broke the build on buildfarm member mongoose.

This is the change I made to contrib/cube.  I see other contrib modules
including fmgr.h too:
	
	diff --git a/contrib/cube/cubedata.h b/contrib/cube/cubedata.h
	new file mode 100644
	index fd0c26a..9760162
	*** a/contrib/cube/cubedata.h
	--- b/contrib/cube/cubedata.h
	***************
	*** 1,5 ****
	--- 1,7 ----
	  /* contrib/cube/cubedata.h */
	
	+ #include "fmgr.h"
	+
	  #define CUBE_MAX_DIM (100)
	
	  typedef struct NDBOX

I can remove it and we can see if it fixes things.  Should I?

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

In response to

Responses

pgsql-committers by date

Next:From: Bruce MomjianDate: 2011-09-01 02:08:24
Subject: Re: pgsql: Allow more include files to be compiled in their own by adding m
Previous:From: Bruce MomjianDate: 2011-09-01 02:01:30
Subject: pgsql: Fix pg_upgrade to preserve toast relfrozenxids for old 8.3serve

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group