Skip site navigation (1) Skip section navigation (2)

Re: Comments on SQL/Med objects

From: Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Guillaume Lelarge <guillaume(at)lelarge(dot)info>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Comments on SQL/Med objects
Date: 2011-04-01 13:40:50
Message-ID: 20110401224049.7C20.6989961C@metrosystems.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, 31 Mar 2011 11:24:27 -0400
Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Attached.  Foreign tables are already OK, I believe; it's only foreign
> data wrappers and foreign servers that appear to need fixing.

The patch seems good for basic functionarity.  I've tested the patch
and noticed that get_foreign_data_wrapper_oid() is same as
GetForeignDataWrapperOidByName(), so they could be merged.  Also
GetForeignServerOidByName() could be merged.

I changed "foreign data wrapper" in message to "foreign-data wrapper"
for consistency, but it's revertable.

Please see merge_oid_funcs.patch which can be applied onto your patch.

I think some supports can be added for comments on SQL/MED objects.

  - pg_dump support for comment on fdw and server
  - psql describe commands (\dew+ and \des+)
  - psql TAB completion

Please see attached patches for each feature.

While testing pg_dump, I noticed that comment of extension's member
objects are not dumped by pg_dump.  Those comments should be dumped
after CREATE EXTENSION statement?

Regards,
--
Shigeru Hanada

Attachment: 20110401_psql_tab.patch
Description: application/octet-stream (3.0 KB)
Attachment: 20110401_psql_describe.patch
Description: application/octet-stream (42.1 KB)
Attachment: 20110401_pg_dump_support.patch
Description: application/octet-stream (885 bytes)
Attachment: 20110401_merge_oid_funcs.patch
Description: application/octet-stream (7.3 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2011-04-01 13:56:39
Subject: Re: edb-postgres.exe has encountered a problem on windows
Previous:From: Magnus HaganderDate: 2011-04-01 13:21:07
Subject: Re: edb-postgres.exe has encountered a problem on windows

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group