Skip site navigation (1) Skip section navigation (2)

Re: WIP patch: collation assignment algorithm rewrite

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: WIP patch: collation assignment algorithm rewrite
Date: 2011-03-20 19:44:43
Message-ID: 20110320194442.GC4525@svana.org (view raw or flat)
Thread:
Lists: pgsql-hackers
On Sat, Mar 19, 2011 at 05:22:39PM -0400, Tom Lane wrote:
> Attached is a WIP patch to split the expression-tree representation of
> collations into separate fields for input and output collation, and to
> replace the parser's current method of assigning collations with a
> recursive post-pass.  I need to read over it again before committing,
> but I think it's pretty close to ready.

I've looked over the main code and it looks good. While I'm not totally
conviced it has to be done as a seperate pass, this way is exceedingly
readable and clear as to what is going on, which makes me much more
confident of its correctness.

Thanks for going over this.

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog(at)svana(dot)org>   http://svana.org/kleptog/
> Patriotism is when love of your own people comes first; nationalism,
> when hate for people other than your own comes first. 
>                                       - Charles de Gaulle

In response to

Responses

pgsql-hackers by date

Next:From: Andrew TiptonDate: 2011-03-20 20:17:27
Subject: Re: foreign keys for array/period contains relationships
Previous:From: Martijn van OosterhoutDate: 2011-03-20 19:26:30
Subject: Re: Collations versus record-returning functions

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group