Skip site navigation (1) Skip section navigation (2)

Re: btree_gist (was: CommitFest progress - or lack thereof)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, pgsql-hackers(at)postgresql(dot)org, pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: btree_gist (was: CommitFest progress - or lack thereof)
Date: 2011-02-08 22:42:12
Message-ID: 201102082242.p18MgCe11171@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-rrreviewers
Robert Haas wrote:
> On Fri, Feb 4, 2011 at 12:02 PM, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su> wrote:
> > Aha,
> >
> > Teodor sent it to the list Dec 28, see
> > http://archives.postgresql.org/message-id/4D1A1677.80300%40sigaev.ru
> >
> > After a month I didn't see any activity on this patch, so I I added it to
> > https://commitfest.postgresql.org/action/patch_view?id=350 Jan 21
> >
> > Now, I realised it was too late. Added to current commitfest.
> 
> I think this patch missed the deadline for the current CommitFest.
> It's true that it was posted to the list in time, but it's just
> madness to think we can do review in a meaningful way and get done in
> a reasonable time if every patch that's ever been posted is fair game
> to be added to the CommitFest at any point.  I believe it's a
> generally accepted principle that adding things to the CommitFest
> properly is the submitter's responsibility.
> 
> That having been said, this looks like a fairly mechanical change to a
> contrib module that you and Teodor wrote.  So I'd say if you guys are
> confident that it's correct, go ahead and commit.  If you need it
> reviewed, or if you can't commit it in the next week or so, I think
> it's going to have to wait for 9.2.

If you need a +1, agreed.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

In response to

pgsql-hackers by date

Next:From: Simon RiggsDate: 2011-02-08 23:00:03
Subject: Re: [COMMITTERS] pgsql: Extend ALTER TABLE to allow Foreign Keys to be added without ini
Previous:From: Tom LaneDate: 2011-02-08 22:41:01
Subject: Re: Extensions versus pg_upgrade

pgsql-rrreviewers by date

Next:From: Stephen FrostDate: 2011-02-11 21:37:38
Subject: Re: btree_gist (was: CommitFest progress - or lack thereof)
Previous:From: Robert HaasDate: 2011-02-08 03:46:28
Subject: btree_gist (was: CommitFest progress - or lack thereof)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group