Skip site navigation (1) Skip section navigation (2)

Re: SSI patch version 14

From: Dan Ports <drkp(at)csail(dot)mit(dot)edu>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: SSI patch version 14
Date: 2011-02-08 20:53:05
Message-ID: 20110208205305.GY9421@csail.mit.edu (view raw or flat)
Thread:
Lists: pgsql-hackers
One other nit re. the predicate lock table size GUCs: the out-of-memory
case in RegisterPredicateLockingXid (predicate.c:1592 in my tree) gives
the hint to increase max_predicate_locks_per_transaction. I don't think
that's correct, since that GUC isn't used to size SerializableXidHash.

In fact, that error shouldn't arise at all because if there was room in
PredXact to register the transaction, then there should be room to
register it's xid in SerializableXidHash. Except that it's possible for
something else to allocate all of our shared memory and thus prevent
SerializbleXidHash from reaching its intended max capacity.

In general, it might be worth considering making a HTAB's max_size a
hard limit, but that's a larger issue. Here, it's probably worth just
removing the hint.

Dan

-- 
Dan R. K. Ports              MIT CSAIL                http://drkp.net/

In response to

pgsql-hackers by date

Next:From: Dimitri FontaineDate: 2011-02-08 20:53:30
Subject: Re: Extensions versus pg_upgrade
Previous:From: Dimitri FontaineDate: 2011-02-08 20:43:59
Subject: Re: Extensions versus pg_upgrade

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group