hi,

thanks for taking a look.

> yamt(at)mwd(dot)biglobe(dot)ne(dot)jp (YAMAMOTO Takashi) writes:
>> the attached patch is to avoid unnecessary detoast'ing and EOF marker pages
>> when possible.  does it make sense?
> 
> The blob page size is already chosen not to allow for out-of-line
> storage, not to mention that pg_largeobject doesn't have a TOAST table.
> So I think avoiding detoasting is largely a waste of time.

doesn't detoasting involve decompression?

> I'm
> unexcited about the other consideration too --- it looks to me like it
> just makes truncation slower, more complicated, and hence more
> bug-prone, in return for a possible speedup that probably nobody will
> ever notice.

slower?  it depends, i guess.

my primary motivation of that part of the patch was to save some space for
certain workloads.  (besides that, leaving unnecessary rows isn't neat,
but it might be a matter of taste.)

YAMAMOTO Takashi

> 
> 			regards, tom lane
> 
> -- 
> Sent via pgsql-novice mailing list (pgsql-novice(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-novice

In response to

• Re: [HACKERS] systable_getnext_ordered at 2011-02-01 00:02:26 from Tom Lane

pgsql-novice by date

Next:	From: Christian Brennsteiner	Date: 2011-02-01 08:50:06
	Subject: Re: handling concurrency right why am i wrong?
Previous:	From: Amish	Date: 2011-02-01 07:03:39
	Subject: ERROR: invalid datatype 'FILE'

pgsql-hackers by date

Next:	From: Dave Page	Date: 2011-02-01 08:47:58
	Subject: Re: setlocale and gettext in Postgres
Previous:	From: Magnus Hagander	Date: 2011-02-01 08:29:34
	Subject: Re: setlocale and gettext in Postgres