From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgindent and line length |
Date: | 2011-01-25 03:02:34 |
Message-ID: | 201101250302.p0P32Y911232@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> Somehow, pgindent appears to have this approach to push lines that are
> longer than the defined line length limit back to the left to make it
> fit. That results in something like this:
>
> printfPQExpBuffer(&buf,
> "SELECT n.nspname as \"%s\",\n"
> " p.proname AS \"%s\",\n"
> " pg_catalog.format_type(p.prorettype, NULL) AS \"%s\",\n",
> gettext_noop("Schema"),
> gettext_noop("Name"),
> gettext_noop("Result data type"));
>
> where the third line of the string was moved to the left.
>
> I don't think this behavior is useful. If the line is too long and
> cannot be split, then it is still more useful to be able locate the
> start of the line in an expected position than to have the end of the
> line on the hypothetical screen. You'll have to scroll right anyway
> because there are usually lines that are going to be too long anyway.
>
> Can we get rid of this behavior?
I think we will have to switch to another indent binary to do that
because it is done by BSD indent and I can't think of a way of fixing it
with pre or post processing.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-01-25 03:13:32 | Re: pgindent and line length |
Previous Message | Richard Broersma | 2011-01-25 02:43:07 | Re: [HACKERS] Seeking Mentors for Funded Reviewers |