Skip site navigation (1) Skip section navigation (2)

Re: Error code for "terminating connection due to conflict with recovery"

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: robertmhaas(at)gmail(dot)com
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Error code for "terminating connection due to conflict with recovery"
Date: 2011-01-13 07:13:09
Message-ID: 20110113.161309.142637155940518140.t-ishii@sraoss.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackers
>>> That doesn't sound right to me.  I'd have thought something in class 40.
>>
>> What about:
>>
>> 40004 CONFLICT WITH RECOVERY conflict_with_recovery
> 
> We should respect the following convention, from errcodes.h:
> 
>  * The convention is that new error codes defined by PostgreSQL in a
>  * class defined by the standard have a subclass value that begins
>  * with 'P'. In addition, error codes defined by PostgreSQL clients
>  * (such as ecpg) have a class value that begins with 'Y'.
> 
> And don't forget there are three places where the new error code would
> need to be added.
> 
> Otherwise, +1.

Ok. Here is the patch for this. I use 40P02, instead of 40004.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp

Attachment: sr_error_code.patch
Description: text/x-patch (2.0 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2011-01-13 07:24:31
Subject: Change pg_last_xlog_receive_location not to move backwards
Previous:From: Alex HunsakerDate: 2011-01-13 07:06:33
Subject: Re: arrays as pl/perl input arguments [PATCH]

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group