Skip site navigation (1) Skip section navigation (2)

pgAdmin III commit: Make sure no query more than max size is stored...

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: pgAdmin III commit: Make sure no query more than max size is stored...
Date: 2010-12-26 09:39:31
Message-ID: 201012260939.oBQ9dVjC077331@gothos.postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Make sure no query more than max size is stored...

in the historic file.

The issue was that, if pgAdmin was killed, the last query, whatever its size,
remained in the histoqueries file. I changed the behabiour so that it can't
happen anymore.

Old behaviour:

  When query is launched
    Save query
  When query is done
    If unsuccessul
      Delete query
    If successful
      If it's bigger than max size
        Delete query
      Else if already present
        Delete the old one

New behaviour

  When query is done
    If successful
      If it's less than max size
        Add query
      If already present
        Delete the old one

Per discussion with Dave Page and Michael Willekes.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=97ac2e2ed0d97e24a124f983f103687a692c3fe2

Modified Files
--------------
CHANGELOG                |    2 ++
pgadmin/frm/frmQuery.cpp |   38 +++++++++++++-------------------------
2 files changed, 15 insertions(+), 25 deletions(-)

pgadmin-hackers by date

Next:From: Hiroshi SaitoDate: 2010-12-26 13:34:53
Subject: Re: utffile symbol defined is strange.
Previous:From: Guillaume LelargeDate: 2010-12-25 17:23:10
Subject: pgAdmin website commit: Update website's french translation.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group