Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Remove outdated comments from the regression test files.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Remove outdated comments from the regression test files.
Date: 2010-11-27 19:49:37
Message-ID: 201011271949.oARJnba22910@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Robert Haas wrote:
> >> Remove outdated comments from the regression test files.
> >> 
> >> Since 2004, int2 and int4 operators do detect overflow; this was fixed by
> >> commit 4171bb869f234281a13bb862d3b1e577bf336242.
> >> 
> >> Extracted from a larger patch by Andres Freund.
> 
> > I noticed with this commit that we are referencing pre-git-conversion
> > git branches, basically adding a dependency on git to our commit
> > messages.  I don't see a problem with this, but did we ever reference
> > CVS details in CVS commits?  I don't remember any.
> 
> I've usually preferred to use a date, eg, "my patch of 2009-10-07",
> when referring to previous patches in commit messages.  I think people
> have occasionally mentioned CVS revision IDs, but the folly of that
> should now be obvious.  I agree that reference to a git hash is way
> way way too fragile and git-centric.

Who's going to be the first to say that being git-centric can't ever be
a bad thing?  ;-)

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2010-11-27 20:29:20
Subject: Re: pgsql: Remove outdated comments from the regression test files.
Previous:From: Tom LaneDate: 2010-11-27 19:46:56
Subject: Re: pgsql: Remove outdated comments from the regression test files.

pgsql-committers by date

Next:From: Robert HaasDate: 2010-11-27 20:29:20
Subject: Re: pgsql: Remove outdated comments from the regression test files.
Previous:From: Tom LaneDate: 2010-11-27 19:46:56
Subject: Re: pgsql: Remove outdated comments from the regression test files.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group